Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pytest make report #2461

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Fix pytest make report #2461

merged 2 commits into from
Mar 17, 2023

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Mar 16, 2023

Fix #2460

alexcjohnson
alexcjohnson approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Seems like it would be pretty annoying to write a test for this, I guess we just rely on the community to tell us about that 🤠

@RonnyPfannschmidt
Copy link

it may be reasonably simply to combine the pytester plugin plus a monkeypatch 🤞

@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Mar 16, 2023
Merged
@T4rk1n
Copy link
Contributor Author

T4rk1n commented Mar 16, 2023

Seems like it would be pretty annoying to write a test for this,

Maybe a ci container that install just dash without testing and a very simple test to pass.

@alexcjohnson
Copy link
Collaborator

Sure. If you think that's going to take time we can merge as is, release a patch, and add that test later.

@T4rk1n T4rk1n force-pushed the fix-2460 branch 2 times, most recently from 0f2e441 to 5b8ec5e Compare March 17, 2023 13:23
@T4rk1n T4rk1n merged commit 55b7674 into dev Mar 17, 2023
@T4rk1n T4rk1n deleted the fix-2460 branch March 17, 2023 14:00
@MatthewMiddlehurst MatthewMiddlehurst mentioned this pull request Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] pytest_runtest_makereport "did not yield"
3 participants
@T4rk1n @RonnyPfannschmidt @alexcjohnson